[ 
https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841860#comment-16841860
 ] 

Danny Chan commented on CALCITE-2969:
-------------------------------------

Thanks for all of your nice review comments [~julianhyde] [~hyuan] [~zabetak] 
[~rubenql], i think the PR is kind of stable now(no vital bugs).

So i'm planning to merge this PR in 24 hours if there are no more comments. Be 
free to fire new comments and i'm glad to do fix up in later patches if we 
really found some fatal defects with current patch.

> Improve design of join-like relational expressions
> --------------------------------------------------
>
>                 Key: CALCITE-2969
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2969
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 23h 10m
>  Remaining Estimate: 0h
>
> The existing join-like (Join, SemiJoin, Correlate, etc.) logical and physical 
> relational expressions have a few design issues which make some parts of the 
> codebase complicated and difficult to understand.
> The goal of this ticket is to improve the design of the respective 
> expressions based on the discussion in the dev list (see thread [Join, 
> SemiJoin, 
> Correlate|https://mail-archives.apache.org/mod_mbox/calcite-dev/201903.mbox/%3C8EEA04A0-4A77-4283-BD20-B019E19AE126%40apache.org%3E]).
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to