[ 
https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842134#comment-16842134
 ] 

Stamatis Zampetakis commented on CALCITE-2969:
----------------------------------------------

Thanks for the reminder [~danny0405]! Indeed the PR is in good shape.

However, I think we should not rush it since it is a big and important 
refactoring. The 24h window may be a bit short for some people. Moreover there 
are still open conversations on GitHub which I think should be resolved (by the 
reviewers) before proceeding. [~vlsi] has also done some comments so I am 
putting him in the conversation. 

> Improve design of join-like relational expressions
> --------------------------------------------------
>
>                 Key: CALCITE-2969
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2969
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.19.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 23h 10m
>  Remaining Estimate: 0h
>
> The existing join-like (Join, SemiJoin, Correlate, etc.) logical and physical 
> relational expressions have a few design issues which make some parts of the 
> codebase complicated and difficult to understand.
> The goal of this ticket is to improve the design of the respective 
> expressions based on the discussion in the dev list (see thread [Join, 
> SemiJoin, 
> Correlate|https://mail-archives.apache.org/mod_mbox/calcite-dev/201903.mbox/%3C8EEA04A0-4A77-4283-BD20-B019E19AE126%40apache.org%3E]).
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to