[ 
https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031626#comment-17031626
 ] 

Vladimir Sitnikov commented on CALCITE-3285:
--------------------------------------------

[~rubenql], does 
[https://github.com/apache/calcite/pull/1702/commits/267e64c51e766d4d2ee05cec433b2759c87284a0]
 (it is a part of PR1788) solve the issue?

I think so.

I'm -1 adding various `non-equi join` to linq4j API provided they add no value.

 

I think the proper implementation should support "less than" kind of joins. 
However, I doubt that implementation is possible with `Predicate` style 
condition.

So adding Predicate argument does not leave room for future improvements.

> EnumerableMergeJoin should support non-equi join conditions
> -----------------------------------------------------------
>
>                 Key: CALCITE-3285
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3285
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Haisheng Yuan
>            Assignee: Vladimir Sitnikov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Calcite should be able to generate EnumerableMergeJoin with non-equi join 
> conditions, as long as there are equi-join conditions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to