[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077451#comment-17077451
]
Haisheng Yuan commented on CALCITE-2970:
----------------------------------------
{quote}
But physical rules do more than convert logical to physical.
{quote}
Physical rules should do just convert logical to physical. If you are
encouraging we do more than convert logical to physical, you are leading us to
the direction departing away from Cascades framework. Currently VolcanoPlanner
doesn't provide built-in mechanism to require or derive physical properties,
the only way to do this is through rule, that is also why people are doing more
than what they are supposed to do in the physical implementation rule. What I
am trying to do is add built-in mechanism to require and derive physical
property into VolcanoPlanner so that implementation rule just convert logical
to physical, nothing more.
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
