[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077565#comment-17077565
 ] 

Julian Hyde commented on CALCITE-2970:
--------------------------------------

I don't think we need to choose a winner. Both processes are fine.

I wanted to push back on your assertion that RelBuilder is not good for 
physical. There are forms of physical optimization (e.g. welding operators 
together, choosing parallelism and resource allocation) where I think Calcite's 
approach - RelOptRules for transformation, maybe cost-based and maybe not, 
using RelBuilder tactically inside rules - is valid.

I am not as inclined as you are to stick strictly to the recommendations of 
Cascades. Treating convention as just another physical property is an 
intentional break from Volcano/Cascades. And our framework (in particular 
RelOptRules) can use engines other than Volcano to schedule transformations. 
So, whatever works.

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 12h
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to