[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085312#comment-17085312
 ] 

Julian Hyde commented on CALCITE-2970:
--------------------------------------

Rather than {{RelBuilder getRelBuilder(RelOptCluster)}} how about 
{{UnaryOperator<RelBuilder> getRelBuilderTransform()}}? The transform would 
take an existing {{RelBuilder}} and switch it to use the convention.

Rationale:
* Conventions are static - i.e. created before queries - and therefore they 
probably don't have the resources to create a RelBuilder.
* And Conventions they work by creating a RelBuilder, that won't compose with 
some other component that works by creating a RelBuilder. 

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to