[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095539#comment-17095539
]
Stamatis Zampetakis commented on CALCITE-2970:
----------------------------------------------
{{RelBuilderFactory}} seems to exactly the abstraction that we want. Why not
make Convention simply return a factory?
{code:java}
default RelBuilderFactory getRelFactory() {
return RelFactories.LOGIGAL_BUILDER;
}
{code}
As I wrote also in the PR, like that we may not need to introduce new
getters/setters in the {{RelBuilder}}.
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
