[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095888#comment-17095888
]
Stamatis Zampetakis commented on CALCITE-2970:
----------------------------------------------
Haha indeed [~hyuan] :)
Seeing the code, the discussion here, and reading the javadoc of
RelBuilderFactory, {{Convention#getRelFactory}} seems like the perfect fit.
Thinking for the future is a must but in this case RelBuilderFactory is more
than enough for the needs of this use-case, and leads to simpler code.
Is there is an actual need to introduce the {{transformRelBuilder}} and the
other APIs instead of the simpler {{getRelFactory}} ?
To put the question a bit differently, if we go for {{Convetion#getRelFactory}}
is there a thing that your downstream project cannot do?
Aside from that having a {{RelBuilder}} that starts by creating
{{EnumerableTableScan}} and then switches to create {{CassandraTableScan}}
seems a bit confusing. Do you need this functionality?
> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
> Key: CALCITE-2970
> URL: https://issues.apache.org/jira/browse/CALCITE-2970
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Haisheng Yuan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 17h 10m
> Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by
> making {{useAbstractConvertersForConversion}} return true,
> {{JDBCTest.testJoinManyWay}} will not complete.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
