[ 
https://issues.apache.org/jira/browse/CALCITE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321205#comment-17321205
 ] 

Julian Hyde commented on CALCITE-4580:
--------------------------------------

The existing {{class SqlCreateTable}} extends {{SqlCreate}} extends {{SqlDdl}} 
extends {{SqlCall}} extends {{SqlNode}}. You should pause for thought why the 
author (me, as it happens) did not simply make {{SqlCreateTable}} extend 
{{SqlNode}}.

> Change the visibility for SqlNode constructor
> ---------------------------------------------
>
>                 Key: CALCITE-4580
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4580
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Konstantin Orlov
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the constructor is package private. That forces developers 
> extending the parser to put all custom nodes under {{org.apache.calcite.sql}} 
> package (or at least create one abstract node {{MySqlNode}} extending 
> {{SqlNode}} and exposing the constructor). It would nice to have the 
> constructor exposed by {{SqlNode}} itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to