[
https://issues.apache.org/jira/browse/CALCITE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322403#comment-17322403
]
Konstantin Orlov commented on CALCITE-4580:
-------------------------------------------
bq. we require that you create a {{SqlOperator}} instance ... and bind it to a
... {{SqlCall}}
This was unclear to me. Thanks for clarification!
bq. Hey, look: public List<Pair<SqlIdentifier, SqlNode>>
SqlCreateForeignSchema.options().
It is the approach #1. Sure this would work, but, personally, I prefer to have
a separate AST node with meaningful name.
> Change the visibility for SqlNode constructor
> ---------------------------------------------
>
> Key: CALCITE-4580
> URL: https://issues.apache.org/jira/browse/CALCITE-4580
> Project: Calcite
> Issue Type: Task
> Reporter: Konstantin Orlov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the constructor is package private. That forces developers
> extending the parser to put all custom nodes under {{org.apache.calcite.sql}}
> package (or at least create one abstract node {{MySqlNode}} extending
> {{SqlNode}} and exposing the constructor). It would nice to have the
> constructor exposed by {{SqlNode}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
