[
https://issues.apache.org/jira/browse/CALCITE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322369#comment-17322369
]
Julian Hyde commented on CALCITE-4580:
--------------------------------------
{quote}An approach #3 is to give an ability to create an arbitrary nodes the
developer want without forcing to stick with a particular package. I think this
is better fits the system positioned as framework.
{quote}
Frameworks that adopt that approach die within a couple of years because they
can't change anything without breaking existing uses of the framework.
There *is* a rationale behind what we have done in Calcite, even if you can't
see it.
> Change the visibility for SqlNode constructor
> ---------------------------------------------
>
> Key: CALCITE-4580
> URL: https://issues.apache.org/jira/browse/CALCITE-4580
> Project: Calcite
> Issue Type: Task
> Reporter: Konstantin Orlov
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the constructor is package private. That forces developers
> extending the parser to put all custom nodes under {{org.apache.calcite.sql}}
> package (or at least create one abstract node {{MySqlNode}} extending
> {{SqlNode}} and exposing the constructor). It would nice to have the
> constructor exposed by {{SqlNode}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
