[
https://issues.apache.org/jira/browse/CALCITE-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457779#comment-17457779
]
Stamatis Zampetakis commented on CALCITE-4935:
----------------------------------------------
I tend to agree with [~jnadeau] and I think we are in case 2 but it is the
first time that I deal with standalone server so cannot tell for sure what's
the expectations here.
I guess [~elserj] or [~julianhyde] know better how the standalone server is
meant to be consumed.
Indeed relocating log4j2 is not gonna be easy. I was checking a bit more on
this and some problems seems to come from the fact that META-INF/services files
for log4j2 remain untouched while the classes have moved.
{noformat}
jar tf avatica-standalone-server-1.20.0-SNAPSHOT-shadow.jar | grep
"META-INF/services/org.apache.logging"
META-INF/services/org.apache.logging.log4j.spi.Provider
META-INF/services/org.apache.logging.log4j.core.util.ContextDataProvider
META-INF/services/org.apache.logging.log4j.message.ThreadDumpMessage$ThreadInfoFactory
META-INF/services/org.apache.logging.log4j.util.PropertySource
{noformat}
> Avatica standalone-server shades log4j without relocation
> ---------------------------------------------------------
>
> Key: CALCITE-4935
> URL: https://issues.apache.org/jira/browse/CALCITE-4935
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Fix For: avatica-1.20.0
>
> Attachments: screenshot-1.png
>
>
> The issue has been found during the vote for avatica-1.20.0 RC0.
> The standalone-server jar in the [staged maven
> repository|https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/avatica/avatica-standalone-server/1.20.0/avatica-standalone-server-1.20.0.jar]
> contains log4j2 classes but they are not relocated.
> In previous, Avatica versions (e.g., avatica-1.19.0), log4j classes were all
> relocated to avoid classpath problems with other libraries/apps potentially
> using another log4j2 version.
> It seems that relocation was dropped in possibly unintenionally in
> CALCITE-4152.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
