[
https://issues.apache.org/jira/browse/CALCITE-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458053#comment-17458053
]
Stamatis Zampetakis commented on CALCITE-4935:
----------------------------------------------
It seems that in the end we all agree that relocation is probably not necessary
for standalone-server so we are fine with this part.
What we need to agree right now is if we want to allow the standalone-server to
be able log messages out of the box or not.
# Yes, show log messages simply by running java -jar standalone-server.jar by
including (shading) the log4j2 classes in the standalone-server.jar
# No, leave the logging choice to the end user/developper and don't include any
concrete log implementation in the standalone-server.jar
If the answer is yes then we can mark this JIRA as won't fix/not a problem and
move forward but we don't allow anyone to choose another logging framework when
using the standalone-server.jar.
If the answer is no, then there is another minor change needed to remove the
log4j classes from the jar file. Like that a user will not see any log messages
unless they provide an SLF4J binding in the classpath (Log4j2 or other).
Since in the past we always had log messages by default when running the
standalone-server I am inclined towards option 1 with no strong preference. Let
me know what do you think so we can close this ASAP.
(Similar discussion should be done for TCK module but let's track in under
another JIRA).
> Avatica standalone-server shades log4j without relocation
> ---------------------------------------------------------
>
> Key: CALCITE-4935
> URL: https://issues.apache.org/jira/browse/CALCITE-4935
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Fix For: avatica-1.20.0
>
> Attachments: screenshot-1.png
>
>
> The issue has been found during the vote for avatica-1.20.0 RC0.
> The standalone-server jar in the [staged maven
> repository|https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/avatica/avatica-standalone-server/1.20.0/avatica-standalone-server-1.20.0.jar]
> contains log4j2 classes but they are not relocated.
> In previous, Avatica versions (e.g., avatica-1.19.0), log4j classes were all
> relocated to avoid classpath problems with other libraries/apps potentially
> using another log4j2 version.
> It seems that relocation was dropped in possibly unintenionally in
> CALCITE-4152.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
