[ 
https://issues.apache.org/jira/browse/CALCITE-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457795#comment-17457795
 ] 

Josh Elser commented on CALCITE-4935:
-------------------------------------

The point of the standalone server jar was to give you a way to launch avatica 
against any database via a "java -cp" command. It makes testing Julian's hsqdb 
Scott dataset easy, for example.

 

Removing the relocation for slf4j and log4j were to avoid needing to make extra 
implementations to use standard logger configuration. I don't remember why I 
had to undo it for Jetty too (but I imagine it was broken).

 

If we do relocate them, we'll have to do the relocation like Stamatis said and 
also document how you change the logging config.

> Avatica standalone-server shades log4j without relocation
> ---------------------------------------------------------
>
>                 Key: CALCITE-4935
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4935
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>             Fix For: avatica-1.20.0
>
>         Attachments: screenshot-1.png
>
>
> The issue has been found during the vote for avatica-1.20.0 RC0.
> The standalone-server jar in the [staged maven 
> repository|https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/avatica/avatica-standalone-server/1.20.0/avatica-standalone-server-1.20.0.jar]
>  contains log4j2 classes but they are not relocated. 
> In previous, Avatica versions (e.g., avatica-1.19.0), log4j classes were all 
> relocated to avoid classpath problems with other libraries/apps potentially 
> using another log4j2 version.
> It seems that relocation was dropped in possibly unintenionally in 
> CALCITE-4152.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to