[
https://issues.apache.org/jira/browse/CALCITE-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611771#comment-17611771
]
Julian Hyde edited comment on CALCITE-5280 at 9/30/22 9:23 PM:
---------------------------------------------------------------
+1
I'd include the names of the functions in the commit message, "Add geometry
aggregate functions (ST_Accum, ST_Collect, and ST_Union)" because concrete is
better.
When I merge, I'll add a release note about the ST_Union → St_UnaryUnion
breaking change.
The PR is draft. Let me know when it's ready.
was (Author: julianhyde):
+1
I'd include the names of the functions in the commit message, "Add geometry
aggregate functions
(ST_Accum, ST_Collect, and ST_Union)" because concrete is better.
> Implement geometry aggregate functions
> --------------------------------------
>
> Key: CALCITE-5280
> URL: https://issues.apache.org/jira/browse/CALCITE-5280
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Bertil Chapuis
> Assignee: Bertil Chapuis
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union) are
> currently missing in Calcite. Using an AggregateFunctionImpl looks be pretty
> straightforward, but many aggregate function implement SqlAggFunction
> directly.
> [~julianhyde] What would be the best way to implement them?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
