[
https://issues.apache.org/jira/browse/CALCITE-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951601#comment-17951601
]
Julian Hyde commented on CALCITE-7016:
--------------------------------------
Can you give an example commit that added a relFn-based test and also added
SQL?
When I created RelOptRulesTest I thought it would be useful to put SQL in the
XML file even though it is a little redundant. I thought it would make it
easier for people to read just the XML file and understand what was going on.
Is this related to the problem you see?
Is your main concern redundant information leading to inconsistency? If so,
removing the redundancy is one solution, but another is to detect redundancy,
give an error, and give people chance to fix it.
> Sql resources should not be included in XML when using relFn in
> RelOptRulesTest testing
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-7016
> URL: https://issues.apache.org/jira/browse/CALCITE-7016
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zhen Chen
> Assignee: Zhen Chen
> Priority: Minor
>
> Use relFn to construct a plan for rule validation, and SQL resources should
> not be included in the result file(RelOptRulesTest.xml). If SQL can be used
> to generate plans, it is not recommended to use relFn for construction.
> Otherwise, it may lead to incorrect mapping between sql and planBefore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
