[ 
https://issues.apache.org/jira/browse/CAMEL-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594891#comment-13594891
 ] 

Aaron Whiteside commented on CAMEL-6130:
----------------------------------------

I've had more time to think about this, and I don't think we should go with 
this approach.

In endpoint helper we would have to call Registry.findByTypeWithName() passing 
Object.class then index into the result keyed by the bean name to get the 
object. 

I'm not sure that all Registry implementations would work correctly this way? 
For me at least it still makes more sense to figure out the specific type and 
try and lookup a bean with that specific type and name.

What do you think?
                
> EndpointHelper.setReferenceProperties() does not work with OSGiServiceRegistry
> ------------------------------------------------------------------------------
>
>                 Key: CAMEL-6130
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6130
>             Project: Camel
>          Issue Type: Bug
>          Components: osgi
>    Affects Versions: 2.9.5, 2.10.4
>            Reporter: Aaron Whiteside
>            Priority: Critical
>             Fix For: 2.9.7, 2.10.5, 2.11.0
>
>         Attachments: CAMEL-6130.patch
>
>
> EndpointHelper.setReferenceProperties() does not work with OSGiServiceRegistry
> setReferenceProperties() is hard-coded to lookup services of type 
> Object.class.
> It should use reflection to determine the type that the setter method accepts 
> and then use that type to lookup the reference in the service registry.
> At the moment this issue is stopping #bean references in Endpoints from being 
> resolved when using an OSGiServiceRegistry, in OSGi you need to know the 
> class of the service you want before hand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to