[
https://issues.apache.org/jira/browse/CAMEL-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897850#comment-16897850
]
Stig Rohde Døssing commented on CAMEL-13752:
--------------------------------------------
I have a rewrite of BridgePropertyPlaceholderConfigurer ready. It's blocked by
https://github.com/spring-projects/spring-framework/pull/23377. Will open a PR
to Camel once that issue is resolved.
> Make a BridgePropertyPlaceholderConfigurer equivalent for
> PropertySourcePlaceholderConfigurer
> ---------------------------------------------------------------------------------------------
>
> Key: CAMEL-13752
> URL: https://issues.apache.org/jira/browse/CAMEL-13752
> Project: Camel
> Issue Type: New Feature
> Components: camel-spring
> Affects Versions: 2.24.1, 3.0.0.M4
> Reporter: Stig Rohde Døssing
> Priority: Minor
>
> BridgePropertyPlaceholderConfigurer extends Spring's
> PropertyPlaceholderConfigurer. Spring recommends against using this class for
> new code, and has a replacement in the PropertySourcesPlaceholderConfigurer.
> The new class is a prerequisite for e.g. the @TestPropertySource annotation
> to work. Example usage here
> https://github.com/apache/camel/blob/camel-2.23.1/components/camel-test-spring/src/test/java/org/apache/camel/test/spring/CamelSpringRunnerTestPropertySourceTest.java
> It's not obvious to me whether it would be safe to reimplement
> BridgePropertyPlaceholderConfigurer to extend
> PropertySourcesPlaceholderConfigurer instead. I'd guess it wouldn't be
> backwards compatible, otherwise Spring would probably have just reimplemented
> PropertyPlaceholderConfigurer.
> I think we should add a new BridgePropertySourcesPlaceholderConfigurer that
> extends PropertySourcesPlaceholderConfigurer. This will allow users to use
> the Camel property bridging functionality, without losing the ability to
> override Spring properties in tests.
> I am happy to work on this if the idea makes sense.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
