[
https://issues.apache.org/jira/browse/CAMEL-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962804#comment-16962804
]
Claus Ibsen commented on CAMEL-13752:
-------------------------------------
Okay so the spring PR is maybe not likely to get merged or what?
And without this PR you have copied some code or what in the Camel PR so it can
work still?
> Make a BridgePropertyPlaceholderConfigurer equivalent for
> PropertySourcePlaceholderConfigurer
> ---------------------------------------------------------------------------------------------
>
> Key: CAMEL-13752
> URL: https://issues.apache.org/jira/browse/CAMEL-13752
> Project: Camel
> Issue Type: New Feature
> Components: camel-spring
> Affects Versions: 2.24.1, 3.0.0.M4
> Reporter: Stig Rohde Døssing
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> BridgePropertyPlaceholderConfigurer extends Spring's
> PropertyPlaceholderConfigurer. Spring recommends against using this class for
> new code, and has a replacement in the PropertySourcesPlaceholderConfigurer.
> The new class is a prerequisite for e.g. the @TestPropertySource annotation
> to work. Example usage here
> https://github.com/apache/camel/blob/camel-2.23.1/components/camel-test-spring/src/test/java/org/apache/camel/test/spring/CamelSpringRunnerTestPropertySourceTest.java
> It's not obvious to me whether it would be safe to reimplement
> BridgePropertyPlaceholderConfigurer to extend
> PropertySourcesPlaceholderConfigurer instead. I'd guess it wouldn't be
> backwards compatible, otherwise Spring would probably have just reimplemented
> PropertyPlaceholderConfigurer.
> I think we should add a new BridgePropertySourcesPlaceholderConfigurer that
> extends PropertySourcesPlaceholderConfigurer. This will allow users to use
> the Camel property bridging functionality, without losing the ability to
> override Spring properties in tests.
> I am happy to work on this if the idea makes sense.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
