[
https://issues.apache.org/jira/browse/CAMEL-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963234#comment-16963234
]
Stig Rohde Døssing commented on CAMEL-13752:
--------------------------------------------
I'm not sure it will get merged. No one seems to have looked at it yet, so I
don't know if it's unacceptable, or the Spring people just haven't gotten
around to looking at it.
Yes, without that PR, I've copied some of the implementation of
PropertyPlaceholderSourcesConfigurer from Spring to Camel, so it should be able
to work without that PR. Since the copied code is most of the
PropertyPlaceholderSourcesConfigurer implementation, it might be a better
option to make the Camel class completely independent of the Spring class,
until/unless Spring merges the PR, as we're not really gaining much from the
coupling.
> Make a BridgePropertyPlaceholderConfigurer equivalent for
> PropertySourcePlaceholderConfigurer
> ---------------------------------------------------------------------------------------------
>
> Key: CAMEL-13752
> URL: https://issues.apache.org/jira/browse/CAMEL-13752
> Project: Camel
> Issue Type: New Feature
> Components: camel-spring
> Affects Versions: 2.24.1, 3.0.0.M4
> Reporter: Stig Rohde Døssing
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> BridgePropertyPlaceholderConfigurer extends Spring's
> PropertyPlaceholderConfigurer. Spring recommends against using this class for
> new code, and has a replacement in the PropertySourcesPlaceholderConfigurer.
> The new class is a prerequisite for e.g. the @TestPropertySource annotation
> to work. Example usage here
> https://github.com/apache/camel/blob/camel-2.23.1/components/camel-test-spring/src/test/java/org/apache/camel/test/spring/CamelSpringRunnerTestPropertySourceTest.java
> It's not obvious to me whether it would be safe to reimplement
> BridgePropertyPlaceholderConfigurer to extend
> PropertySourcesPlaceholderConfigurer instead. I'd guess it wouldn't be
> backwards compatible, otherwise Spring would probably have just reimplemented
> PropertyPlaceholderConfigurer.
> I think we should add a new BridgePropertySourcesPlaceholderConfigurer that
> extends PropertySourcesPlaceholderConfigurer. This will allow users to use
> the Camel property bridging functionality, without losing the ability to
> override Spring properties in tests.
> I am happy to work on this if the idea makes sense.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
