[GitHub] carbondata pull request #1751: [CARBONDATA-1971][Blocklet Prunning] Measure ...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r162053147
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
 ---
    @@ -196,6 +201,10 @@ private DataMapRowImpl loadToUnsafe(DataFileFooter 
fileFooter,
               unsafeMemorySummaryDMStore.getSchema()[taskMinMaxOrdinal], 
maxValues,
               TASK_MAX_VALUES_INDEX, false);
           ordinal++;
    +      taskMinMaxOrdinal++;
    +
    +      summaryRow.setByteArray(minMaxIndex.getNullValues().toByteArray(), 
taskMinMaxOrdinal);
    --- End diff --
    
    We need to calculate null bits based on whole blocks and then set to the 
summary


---