Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1751#discussion_r162290297
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
 ---
    @@ -196,6 +201,10 @@ private DataMapRowImpl loadToUnsafe(DataFileFooter 
fileFooter,
               unsafeMemorySummaryDMStore.getSchema()[taskMinMaxOrdinal], 
maxValues,
               TASK_MAX_VALUES_INDEX, false);
           ordinal++;
    +      taskMinMaxOrdinal++;
    +
    +      summaryRow.setByteArray(minMaxIndex.getNullValues().toByteArray(), 
taskMinMaxOrdinal);
    --- End diff --
    
    Added new routine addTaskNullValues which is going to OR all the Null 
Bitsets from all the blocklets and place the final value into the summary row. 
Like the one done for minMax. 


---

Reply via email to