Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1751#discussion_r162289986
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeLessThanEqualFilterExecuterImpl.java
---
@@ -150,14 +155,17 @@ private boolean isScanRequired(byte[] blockMinValue,
byte[][] filterValues) {
return isScanRequired;
}
- private boolean isScanRequired(byte[] minValue, Object[] filterValue,
+ private boolean isScanRequired(byte[] minValue, boolean nullValue,
Object[] filterValue,
DataType dataType) {
Object value =
DataTypeUtil.getMeasureObjectFromDataType(minValue, dataType);
for (int i = 0; i < filterValue.length; i++) {
- // TODO handle min and max for null values.
if (filterValue[i] == null) {
- return true;
+ if (nullValue == true) {
+ return true;
+ } else {
+ return false;
+ }
--- End diff --
Done
---
