Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2134#discussion_r178721496
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/DataMapJob.java ---
    @@ -19,15 +19,21 @@
     import java.io.Serializable;
     import java.util.List;
     
    +import org.apache.carbondata.core.datamap.dev.DataMap;
     import org.apache.carbondata.core.indexstore.ExtendedBlocklet;
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable;
     import org.apache.carbondata.core.scan.filter.resolver.FilterResolverIntf;
     
    +import org.apache.hadoop.mapreduce.lib.input.FileInputFormat;
    +
     /**
      * Distributable datamap job to execute the #DistributableDataMapFormat in 
cluster. it prunes the
      * datamaps distributably and returns the final blocklet list
      */
     public interface DataMapJob extends Serializable {
     
    +  List<DataMap> execute(FileInputFormat<Void, DataMap> dataMapFormat, 
CarbonTable carbonTable);
    +
    --- End diff --
    
    Change the argument order, first should be carbonTable


---

Reply via email to