Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723320
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -177,10 +204,45 @@ public UnsafeDataMapRow getUnsafeRow(int index) {
return new UnsafeDataMapRow(schema, memoryBlock, pointers[index]);
}
- public void finishWriting() throws MemoryException {
+ /**
+ * Add the index row to dataMapRows, basically to in memory.
+ *
+ * @param indexRow
+ * @return
+ */
+ private void addDataMapRow(DataMapRow indexRow) throws MemoryException {
+ dataMapRows.add(indexRow);
+ }
+
+ /**
+ * This method will write all the dataMapRows to unsafe
+ *
+ * @throws MemoryException
+ * @throws IOException
+ */
+ private void adddataMapRowToUnsafe() throws MemoryException, IOException
{
--- End diff --
Correct the typo in method name and rename to addDataMapRowsToUnsafe
---
