Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723089
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -97,12 +119,17 @@ public void addIndexRowToUnsafe(DataMapRow indexRow)
throws MemoryException {
int rowSize = indexRow.getTotalSizeInBytes();
// Check whether allocated memory is sufficient or not.
ensureSize(rowSize);
- int pointer = runningLength;
+ if (addRowToUnsafe) {
+ int pointer = runningLength;
- for (int i = 0; i < schema.length; i++) {
- addToUnsafe(schema[i], indexRow, i);
+ for (int i = 0; i < schema.length; i++) {
+ addToUnsafe(schema[i], indexRow, i);
+ }
+ pointers[rowCount++] = pointer;
+ } else {
+ // add dataMap rows to in memory
+ addDataMapRow(indexRow);
--- End diff --
Rename the method name to addDataMapRowToMemory
---