Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2134#discussion_r178724959
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
 ---
    @@ -156,15 +167,18 @@ private ExtendedBlocklet 
getExtendedBlocklet(List<TableBlockIndexUniqueIdentifie
       @Override
       public List<DataMapDistributable> toDistributable(Segment segment) {
         List<DataMapDistributable> distributables = new ArrayList<>();
    +    Map<String, String> indexFiles = null;
         try {
           CarbonFile[] carbonIndexFiles;
           if (segment.getSegmentFileName() == null) {
             carbonIndexFiles = SegmentIndexFileStore.getCarbonIndexFiles(
                 CarbonTablePath.getSegmentPath(identifier.getTablePath(), 
segment.getSegmentNo()));
           } else {
    +        // TODO: Buggy code, this code will not work as we need to list 
only the
    +        // physically existing files
    --- End diff --
    
    Remove this TODO and handle partition case


---

Reply via email to