Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2113#discussion_r181713300
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
 ---
    @@ -129,9 +130,11 @@ public DiskBasedDMSchemaStorageProvider(String 
storePath) {
         return dataMapSchemas;
       }
     
    -  @Override public void dropSchema(String dataMapName) throws IOException {
    -    String schemaPath =
    -        storePath + CarbonCommonConstants.FILE_SEPARATOR + dataMapName + 
".dmschema";
    +  @Override public void dropSchema(String dataMapName, String tableName, 
String dataMapProviderName)
    +      throws IOException {
    +    String schemaPath = storePath + CarbonCommonConstants.FILE_SEPARATOR + 
tableName
    --- End diff --
    
    make an utility function and use it in all place including testcase


---

Reply via email to