Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2113#discussion_r181725781
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/IndexDataMapProvider.java 
---
    @@ -99,25 +103,24 @@ private DataMapFactory 
createIndexDataMapFactory(DataMapSchema dataMapSchema)
         return dataMapFactory;
       }
     
    -  private DataMapFactory getDataMapFactoryByShortName(String providerName)
    +  public static DataMapFactory getDataMapFactoryByShortName(String 
providerName)
           throws MalformedDataMapCommandException {
    +    
DataMapRegistry.registerDataMap(DataMapClassProvider.LUCENE.getClassName(),
    --- End diff --
    
    What is the need of specifing the LUCENE here, these classes are supposed 
to be independent on any specific datamap.


---

Reply via email to