Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2113#discussion_r181727647
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
 ---
    @@ -69,8 +69,29 @@ case class CarbonCreateDataMapCommand(
         }
     
         dataMapSchema = new DataMapSchema(dataMapName, dmClassName)
    -    if (mainTable != null &&
    -        mainTable.isStreamingTable &&
    +    if 
(dataMapSchema.getProviderName.equalsIgnoreCase(DataMapClassProvider.LUCENE.toString))
 {
    --- End diff --
    
    This all validation code should be inside the luceneDatamapFactory init 
method. Please don't add any lucene specific code outside of lucene classes


---

Reply via email to