Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2275#discussion_r187768992
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
---
@@ -107,13 +118,39 @@ public LuceneDataMapFactoryBase(CarbonTable
carbonTable, DataMapSchema dataMapSc
// optimizedOperations.add(ExpressionType.LESSTHAN_EQUALTO);
// optimizedOperations.add(ExpressionType.NOT);
optimizedOperations.add(ExpressionType.TEXT_MATCH);
- this.dataMapMeta = new DataMapMeta(indexedColumns,
optimizedOperations);
-
+ this.dataMapMeta = new DataMapMeta(indexedCarbonColumns,
optimizedOperations);
// get analyzer
// TODO: how to get analyzer ?
analyzer = new StandardAnalyzer();
}
+ public static int validateAndGetWriteCacheSize(DataMapSchema schema) {
+ String cacheStr = schema.getProperties().get(FLUSH_CACHE);
+ if (cacheStr == null) {
+ cacheStr = "-1";
--- End diff --
Better to provide the property default value right below the property name.
---
