Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2275#discussion_r187769052
  
    --- Diff: 
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapRefresher.java
 ---
    @@ -66,20 +62,28 @@
     
       private IndexWriter indexWriter = null;
     
    -  private IndexWriter pageIndexWriter = null;
    -
       private Analyzer analyzer = null;
     
    -  LuceneDataMapRefresher(String tablePath, String dataMapName,
    -      Segment segment, String shardName, List<CarbonColumn> indexColumns) {
    -    this.dataMapPath = CarbonTablePath.getDataMapStorePathOnShardName(
    -        tablePath, segment.getSegmentNo(), dataMapName, shardName);
    +  private int writeCacheSize;
    +
    +  private Map<LuceneDataMapWriter.LuceneColumnKeys, Map<Integer, 
RoaringBitmap>> cache =
    +      new HashMap<>();
    +
    +  private ByteBuffer intBuffer = ByteBuffer.allocate(4);
    +
    +  private boolean storeBlockletWise;
    +
    +  LuceneDataMapRefresher(String tablePath, String dataMapName, Segment 
segment, String shardName,
    +      List<CarbonColumn> indexColumns, int writeCacheSize, boolean 
storeBlockletWise) {
    +    this.dataMapPath = CarbonTablePath
    +        .getDataMapStorePathOnShardName(tablePath, segment.getSegmentNo(), 
dataMapName, shardName);
         this.indexColumns = indexColumns;
         this.columnsCount = indexColumns.size();
    +    this.writeCacheSize = writeCacheSize;
    +    this.storeBlockletWise = storeBlockletWise;
       }
     
    -  @Override
    -  public void initialize() throws IOException {
    +  @Override public void initialize() throws IOException {
    --- End diff --
    
    Move override to the previous line


---

Reply via email to