[GitHub] carbondata pull request #2275: [WIP] Fix lucene datasize and performance

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2275#discussion_r187769065
  
    --- Diff: 
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapRefresher.java
 ---
    @@ -114,108 +118,36 @@ public void initialize() throws IOException {
         indexWriter = new IndexWriter(indexDir, new 
IndexWriterConfig(analyzer));
       }
     
    -  private IndexWriter createPageIndexWriter() throws IOException {
    -    // save index data into ram, write into disk after one page finished
    -    RAMDirectory ramDir = new RAMDirectory();
    -    return new IndexWriter(ramDir, new IndexWriterConfig(analyzer));
    -  }
    -
    -  private void addPageIndex(IndexWriter pageIndexWriter) throws 
IOException {
    -
    -    Directory directory = pageIndexWriter.getDirectory();
    -
    -    // close ram writer
    -    pageIndexWriter.close();
    -
    -    // add ram index data into disk
    -    indexWriter.addIndexes(directory);
    -
    -    // delete this ram data
    -    directory.close();
    -  }
    -
    -  @Override
    -  public void addRow(int blockletId, int pageId, int rowId, Object[] 
values) throws IOException {
    -    if (rowId == 0) {
    -      if (pageIndexWriter != null) {
    -        addPageIndex(pageIndexWriter);
    -      }
    -      pageIndexWriter = createPageIndexWriter();
    -    }
    -
    -    // create a new document
    -    Document doc = new Document();
    -
    -    // add blocklet Id
    -    doc.add(new IntPoint(LuceneDataMapWriter.BLOCKLETID_NAME, (int) 
values[columnsCount]));
    -    doc.add(new StoredField(LuceneDataMapWriter.BLOCKLETID_NAME, (int) 
values[columnsCount]));
    -
    -    // add page id
    -    doc.add(new IntPoint(LuceneDataMapWriter.PAGEID_NAME, (int) 
values[columnsCount + 1]));
    -    doc.add(new StoredField(LuceneDataMapWriter.PAGEID_NAME, (int) 
values[columnsCount + 1]));
    -
    -    // add row id
    -    doc.add(new IntPoint(LuceneDataMapWriter.ROWID_NAME, rowId));
    -    doc.add(new StoredField(LuceneDataMapWriter.ROWID_NAME, rowId));
    +  @Override public void addRow(int blockletId, int pageId, int rowId, 
Object[] values)
    --- End diff --
    
    move override to the previous ine


---