[GitHub] carbondata pull request #2379: [CARBONDATA-2420][32K] Support string longer ...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2379#discussion_r196454746
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
 ---
    @@ -103,6 +103,7 @@ private ColumnPageEncoder 
createEncoderForDimensionLegacy(TableSpec.DimensionSpe
             return new HighCardDictDimensionIndexCodec(
                 dimensionSpec.isInSortColumns(),
    --- End diff --
    
    Instead of passing all the properties of dimensionspec individually, pass 
dimensionspec it self. 


---