Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2379#discussion_r196455199
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
 ---
    @@ -71,7 +72,7 @@ public ColumnPageDecoder createDecoder(List<Encoding> 
encodings, List<ByteBuffer
         byte[] encoderMeta = encoderMetas.get(0).array();
         ByteArrayInputStream stream = new ByteArrayInputStream(encoderMeta);
         DataInputStream in = new DataInputStream(stream);
    -    if (encoding == DIRECT_COMPRESS) {
    +    if (encoding == DIRECT_COMPRESS || encoding == 
DIRECT_COMPRESS_VARCHAR) {
    --- End diff --
    
    why DIRECT_COMPRESS_VARCHAR is required?? you can use DIRECT_COMPRESS for 
varchar


---

Reply via email to