[GitHub] carbondata pull request #2379: [CARBONDATA-2420][32K] Support string longer ...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2379#discussion_r196633906
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
 ---
    @@ -103,6 +103,7 @@ private ColumnPageEncoder 
createEncoderForDimensionLegacy(TableSpec.DimensionSpe
             return new HighCardDictDimensionIndexCodec(
                 dimensionSpec.isInSortColumns(),
    --- End diff --
    
    emm, better not do this in this PR. All the parameters for *IndexCodec 
looks alike. Changing all of them will introduce unrelated changes.


---