Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197486428
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
    @@ -119,9 +143,38 @@ public 
DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
         return listBasedResult;
       }
     
    +  private void fillComplexColumnDataBuffer() {
    +
    +    //    dictionaryComplexColumnIndex = 0;
    +    noDictionaryComplexColumnIndex = 0;
    +    complexTypeComplexColumnIndex = 0;
    +    for (int i = 0; i < queryDimensions.length; i++) {
    +      if (queryDimensions[i].getDimension().getParentOrdinal() != -1) {
    --- End diff --
    
    Take an array and fill the ordinals in a constructor 


---

Reply via email to