Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197491159
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
 ---
    @@ -146,4 +148,58 @@ public PrimitiveQueryType(String name, String 
parentname, int blockIndex,
         return actualData;
       }
     
    +  @Override public Object getDataBasedOnColumn(ByteBuffer dataBuffer, 
CarbonDimension parent,
    +      CarbonDimension child) {
    +    Object actualData = null;
    +
    +    if (parent.getOrdinal() != child.getOrdinal() || null == dataBuffer) {
    +      return null;
    +    }
    +
    +    if (isDirectDictionary) {
    --- End diff --
    
    Remove the duplicate code, code is almost similar to 
`getDataBasedOnDataType`


---

Reply via email to