Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197501751
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -417,6 +417,44 @@ public static Object 
getDataDataTypeForNoDictionaryColumn(String dimensionValue,
         }
       }
     
    +  /**
    +   * Returns true for fixed length DataTypes.
    +   * @param dataType
    +   * @return
    +   */
    +  public static boolean isFixedSizeDataType(DataType dataType) {
    +    if (dataType == DataTypes.STRING || DataTypes.isDecimal(dataType)) {
    +      return false;
    +    } else {
    +      return true;
    +    }
    +  }
    +  /**
    +   * get the size of fixed size DataType
    +   * @param actualDataType
    +   * @return
    +   */
    +  public static int getSizeOfDataType(DataType actualDataType) {
    --- End diff --
    
    Get the size in bytes directly from DataType


---

Reply via email to