Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214629195
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -68,11 +70,14 @@
public CarbonFactDataWriterImplV3(CarbonFactDataHandlerModel model) {
super(model);
- blockletSizeThreshold = Long.parseLong(CarbonProperties.getInstance()
- .getProperty(CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB,
- CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB_DEFAULT_VALUE))
- * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR
- * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
+ String blockletSize =
+
model.getTableSpec().getCarbonTable().getTableInfo().getFactTable().getTableProperties()
+ .get(TABLE_BLOCKLET_SIZE);
+ if (blockletSize == null) {
--- End diff --
If the user does not specify the blocklet size and the blocklet size is
changed during the loading. Will it be a problem?
---
