[GitHub] carbondata pull request #2682: [CARBONDATA-2907] Support setting blocklet si...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2682#discussion_r214705354
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
 ---
    @@ -68,11 +70,14 @@
     
       public CarbonFactDataWriterImplV3(CarbonFactDataHandlerModel model) {
         super(model);
    -    blockletSizeThreshold = Long.parseLong(CarbonProperties.getInstance()
    -        .getProperty(CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB,
    -            CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB_DEFAULT_VALUE))
    -        * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR
    -        * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    String blockletSize =
    +        
model.getTableSpec().getCarbonTable().getTableInfo().getFactTable().getTableProperties()
    +            .get(TABLE_BLOCKLET_SIZE);
    +    if (blockletSize == null) {
    --- End diff --
    
    not a problem. blocklet size is get from the property for every load


---