[GitHub] carbondata pull request #2682: [CARBONDATA-2907] Support setting blocklet si...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2682#discussion_r214629556
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
 ---
    @@ -68,11 +70,14 @@
     
       public CarbonFactDataWriterImplV3(CarbonFactDataHandlerModel model) {
         super(model);
    -    blockletSizeThreshold = Long.parseLong(CarbonProperties.getInstance()
    -        .getProperty(CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB,
    -            CarbonV3DataFormatConstants.BLOCKLET_SIZE_IN_MB_DEFAULT_VALUE))
    -        * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR
    -        * CarbonCommonConstants.BYTE_TO_KB_CONVERSION_FACTOR;
    +    String blockletSize =
    --- End diff --
    
    I didn't see the code to verify this value's correctness


---