Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r216885444
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeCarbonRowPage.java
---
@@ -59,12 +60,11 @@ public UnsafeCarbonRowPage(TableFieldStat
tableFieldStat, MemoryBlock memoryBloc
this.taskId = taskId;
buffer = new IntPointerBuffer(this.taskId);
this.dataBlock = memoryBlock;
- // TODO Only using 98% of space for safe side.May be we can have
different logic.
- sizeToBeUsed = dataBlock.size() - (dataBlock.size() * 5) / 100;
+ sizeToBeUsed = dataBlock.size();
--- End diff --
Is the old comment outdated? Have you ensured the 'safe side' it mentioned?
---
