Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2706#discussion_r216885804
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
 ---
    @@ -240,11 +249,11 @@ public void addRow(Object[] row) throws 
CarbonSortKeyAndGroupByException {
               throw new CarbonSortKeyAndGroupByException(ex);
             }
             rowPage.addRow(row, rowBuffer.get());
    -      } catch (Exception e) {
    -        LOGGER.error(
    -            "exception occurred while trying to acquire a semaphore lock: 
" + e.getMessage());
    -        throw new CarbonSortKeyAndGroupByException(e);
           }
    +    } catch (Exception e) {
    +      LOGGER
    --- End diff --
    
    bad indent. we can move the msg to next line and keep method call in this 
line


---

Reply via email to