Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2706#discussion_r216884722
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/SortStepRowHandler.java
---
@@ -559,7 +572,13 @@ public int
writeRawRowAsIntermediateSortTempRowToUnsafeMemory(Object[] row,
return size;
}
-
+ private void validateUnsafeMemoryBlockSizeLimit(long
unsafeRemainingLength, int size)
--- End diff --
please optimize the parameter name of 'size' for better reading, it seems
that it represents the requestedSize
---