[GitHub] carbondata pull request #2706: [CARBONDATA-2927] multiple issue fixes for va...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2706#discussion_r217987255
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
 ---
    @@ -239,6 +239,7 @@ public void addDataToStore(CarbonRow row) throws 
CarbonDataWriterException {
        * @return false if any varchar column page cannot add one more 
value(2MB)
        */
       private boolean isVarcharColumnFull(CarbonRow row) {
    +    //TODO: test and remove this as now  UnsafeSortDataRows can exceed 2MB
    --- End diff --
    
    This is for a column page cannot exceed 2GB （actually it is 1.67GB since 
snappy cannot compress a bigger size in one run）, so there is no need to add 
a comment here


---