Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2715#discussion_r219747797
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
---
@@ -42,6 +44,112 @@ case class Rcd(booleanField: Boolean, shortField:
Short, intField: Int, bigintFi
dateField: String, charField: String, floatField: Float,
stringDictField: String,
stringSortField: String, stringLocalDictField: String,
longStringField: String)
+/**
+ * This compressor actually will not compress or decompress anything.
+ * It is used for test case of specifying customized compressor.
+ */
+class CustomizeCompressor extends Compressor {
+ override def getName: String =
"org.apache.carbondata.integration.spark.testsuite.dataload.CustomizeCompressor"
--- End diff --
I think it is better if we take shortname from compressor and store only
shortname in carbondata file. And also user can use only short name in
tableproperties while creating table. It should be like how Spark's fileformat
interfaces uses the shortName and resolve the interfaces using the java
service.
---
