Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2738#discussion_r220558655
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java 
---
    @@ -101,6 +101,20 @@ public CarbonReaderBuilder 
withHadoopConf(Configuration conf) {
         return this;
       }
     
    +
    +  public CarbonReaderBuilder withHadoopConf(String[] args) {
    --- End diff --
    
    I think this API is not clear. Instead we can support a method like 
withHadoopConf(String key, String value) then we don't have to parse in SDK 
java layer. C JNI layer can be invoked for every property user wants to 
overwrite
    



---

Reply via email to