Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2738#discussion_r220559298
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -101,6 +101,20 @@ public CarbonReaderBuilder
withHadoopConf(Configuration conf) {
return this;
}
+
+ public CarbonReaderBuilder withHadoopConf(String[] args) {
+ Configuration configuration = new Configuration();
--- End diff --
We should not create every time a new configuration. Should create once
for first time and then update the value for all further calls to this method
---
