Github user KanakaKumar commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2792#discussion_r222689040
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonRecordReader.java ---
    @@ -116,6 +117,25 @@ public void initialize(InputSplit inputSplit, 
TaskAttemptContext context)
         return readSupport.readRow(carbonIterator.next());
       }
     
    +  /**
    +   * get CarbonRow data, including data and datatypes
    +   *
    +   * @return carbonRow object or data array or T
    +   * @throws IOException
    +   * @throws InterruptedException
    +   */
    +  public T getCarbonRow() throws IOException, InterruptedException {
    --- End diff --
    
    I think instead of confusing T, we can define the return type as CarbonRow 
itself


---

Reply via email to